Will a diverter work on any water butt or tank?

As long as it's installed correctly, you shouldn't have an issue with getting it to work. But you're very welcome to check with us if you want any clarifications.